Contributed by ray on from the low-level-packet-scrubbing dept.
If you use networking, please test this diff! Yes, this means you!The following diff is the next step of some further cleaning of the Ethernet ioctl handling code in the Ethernet drivers. This takes advantage of the addition of MTU and multicast handling to ether_ioctl() so some some duplicate code can be removed from the individual drivers and simplifies things a bit.
This needs testing with pretty much every NIC supported. Please send me a dmesg with whatever you are able to test.
This mainly affects multicast handling which is used by things such as IPv6, CARP and OSPF.
(Comments are closed)
By Anonymous Coward (91.113.168.110) on
Does this apply to me?
</sarcasm>
By Anonymous Coward (94.178.0.85) on
Comments
By tedu (udet) on
mail brad a dmesg.
By Anonymous Coward (85.19.213.88) on
By running 4.4-current (FAQ) with a reasonably new source tree (cvs update), applying the diff (patch), compiling a new kernel (FAQ), rebooting and sending the dmesg (/var/run/dmesg.boot) to Brad.
Use your computer for a while. Do the things you normally do and look for any sign of trouble. Running tcpbench(1) or iperf (/usr/ports/net/iperf) for a while could also be beneficial.
Thanks.
Comments
By Anonymous Coward (92.192.126.24) on
>
> applying the diff (patch),
All hunks fail. Could you expand this step to details?
I c&p'ed all the text to a file located in /usr/src/sys/ and did
patch -p0 < <mypatchfile> as described here: http://www.de.openbsd.org/faq/faq10.html#Patches
Thanks,
anon coward
Comments
By tedu (udet) on
> >
> > applying the diff (patch),
>
> All hunks fail. Could you expand this step to details?
> I c&p'ed all the text to a file located in /usr/src/sys/ and did
> patch -p0 < <mypatchfile> as described here: http://www.de.openbsd.org/faq/faq10.html#Patches
Did you copy and paste tabs or spaces? Copy and paste is a terrible way to transfer patches.
By Anonymous Coward (85.19.213.88) on
> >
> > applying the diff (patch),
>
> All hunks fail. Could you expand this step to details?
> I c&p'ed all the text to a file located in /usr/src/sys/
> and did patch -p0 < <mypatchfile> as described here:
> http://www.de.openbsd.org/faq/faq10.html#Patches
As tedu said, copy and paste is a really nice way to screw up an otherwise perfectly fine diff ;-) Try the following instead:
$ curl http://url-to-diff > the.diff
Then apply the.diff
$ patch -d /usr/src/sys -p0 < the.diff
Good luck, and thanks for trying!
Comments
By Anonymous Coward (99.231.56.170) on
FYI: OpenBSD's ftp command can download from HTTP URL's as well.
Comments
By Anonymous Coward (85.19.213.88) on
>
> FYI: OpenBSD's ftp command can download from HTTP URL's as well.
So I noticed. Thank you. I never even considered it, because I've always just used curl.
By Anonymous Coward (167.206.66.94) on
Comments
By Anonymous Coward (92.192.31.133) on
>
> cd /usr/src/sys
> ftp -o - 'http://marc.info/?l=openbsd-tech&m=122716270529285&q=raw' | patch -p0
>
Ah, it's the "download message raw" link :-)
Thanks for pointing this out!
By Anonymous Coward (96.21.15.58) on
In this sense, a lot more people with various other systems could report back, including their desktops at work that run other operating systems, work servers (during hardware upgrades, etc), etc.
At my last job, I had access to a multitude of banking systems/servers that would require a shutdown at times due to failed motherboards, RAID controllers, etc. I could have tested a lot like this but never would they allow us to install another OS than their existing defined standards, obviously.
If I could have followed -current on a livecd, I would have done this every day for the OpenBSD developers...
Just my thoughts.
Comments
By Anthony (2001:470:e828:100:207:e9ff:fe39:24e8) on
By tedu (udet) on
The idea behing testing is to verify "When I upgrade my production machines to this code I know they will still work." If you aren't testing in a replica production environment, you aren't verifying that fact.
installboot in 4.4 is broken in some configs because nobody tested it with them until after release, then it seems everybody with a funky parition table shows up.
The work required to generate such CDs is a lot greater than the benefit of testing on machines that by definition are not reprenetative of production.
By Anonymous Coward (92.112.125.196) on
>
> In this sense, a lot more people with various other systems could report back, including their desktops at work that run other operating systems, work servers (during hardware upgrades, etc), etc.
>
> At my last job, I had access to a multitude of banking systems/servers that would require a shutdown at times due to failed motherboards, RAID controllers, etc. I could have tested a lot like this but never would they allow us to install another OS than their existing defined standards, obviously.
>
> If I could have followed -current on a livecd, I would have done this every day for the OpenBSD developers...
>
> Just my thoughts.
great idea !!!!
Comments
By Anonymous Coward (212.20.215.132) on
> > create a bootable, non-intrusive 'LiveCD or LiveUSB' snapshot
> > version for people to boot off of and obtain these needed
> > dmesg's for them...
[...]
> >
> > Just my thoughts.
>
> great idea !!!!
>
Do you volunteer to create these ISO images and put them online for people to download? The developers are busy enough as it is, working on real issues ;-)
Comments
By René (91.42.57.251) on
>
I can create a snapshot Live-CD from time to time. If there is real interest in such a Live-CD I will do this. I have some experience in creating Live-CDs (look at: http://openbsd.maroufi.net/download_en.shtml)
But: I will only do this if the developers are accepting bug-reports and dmesgs from such a Live-CD and enough people test with this Live-CD.
Comments
By Anonymous Coward (212.20.215.132) on
> and dmesgs from such a Live-CD and enough people test with this Live-CD.
>
I don't think you'll find that out until you actually try this. Create a Live CD ISO image for testing the diff mentioned in this article, put it up for download somewhere (that has enough bandwidth) and announce it on misc@ and perhaps tech@. See what kind of response you get.
This is mostly a "just do it" (aka "shut up and hack") community. So, just do it and either get appreciated or flamed (or both) ;-)
Thanks.
Comments
By Janne Johansson (jj) jj@inet6.se on .
> > and dmesgs from such a Live-CD and enough people test with this Live-CD.
> put it up for download somewhere (that has enough bandwidth) and announce it on misc@ and perhaps tech@.
I have that place, whenever they are ready. I already support
Quetzal (ok, that project fell asleep) and the openbsd-stable unofficial
builds here, so yet another isnt a problem.
By Anonymous Coward (81.165.220.171) on
>
if you do, you probably get flamed by some people because the iso's are insecure and people don't know what you've put on it and blablabla ...
By Ed Ahlsen-Girard (204.49.40.232) ed.ahlsen-girard@tybrin.com on
>
> In this sense, a lot more people with various other systems could report back, including their desktops at work that run other operating systems, work servers (during hardware upgrades, etc), etc.
>
> At my last job, I had access to a multitude of banking systems/servers that would require a shutdown at times due to failed motherboards, RAID controllers, etc. I could have tested a lot like this but never would they allow us to install another OS than their existing defined standards, obviously.
>
> If I could have followed -current on a livecd, I would have done this every day for the OpenBSD developers...
>
> Just my thoughts.
I think the effort of making Live* images for -current would be prohibitive.
Comments
By René (91.42.57.251) on
It's a little bit less prohibitive if I do this on a regular basis with some scripts, and not for -current, but with snapshots.
Next 3 weeks I have not much time, but I will do this with snapshots on a regular basis. If its done you can download Iso-Images on http://openbsd.maroufi.net/livesnapshots.shtml.
By Anonymous Coward (121.54.75.134) on
Comments
By Ray (75.220.94.19) ray@ on http://cyth.net/~ray/
Yup!