Call for Testing: acpiasus(4)

Contributed by tbert on 2014-01-30 from the have-you-tried-turning-it-off-and-on-again dept.

Paul Irofti (pirofti@) posted to tech@ a call for owners of ASUS laptops to test a diff that may fix attach behaviours:

It seems to me that the activate function was registered as a detach
function. This diff puts the activate function in the proper cfattach
position.


Index: dev/acpi/acpiasus.c
===================================================================
RCS file: /cvs/src/sys/dev/acpi/acpiasus.c,v
retrieving revision 1.15
diff -u -p -r1.15 acpiasus.c
--- dev/acpi/acpiasus.c	6 Dec 2013 21:03:02 -0000	1.15
+++ dev/acpi/acpiasus.c	29 Jan 2014 12:57:26 -0000
@@ -88,7 +88,7 @@ extern int wskbd_set_mixervolume(long, l
 
 struct cfattach acpiasus_ca = {
 	sizeof(struct acpiasus_softc), acpiasus_match, acpiasus_attach,
-	acpiasus_activate
+	NULL, acpiasus_activate
 };
 
 struct cfdriver acpiasus_cd = {

As he says in his follow-up email, "People with asus, please test and report back on both success and failure."

(Comments are closed)

Comments

By Paul Irofti (bulibuta) on 2014-01-30 22:12 gopher://sdf.lonestar.org/1/users/bulibuta

Thank you for helping with this announcement.
The diff has been committed in -current so it's even easier to test.

Please let me know if any problems arise with -current (that weren't there before my commit) when suspend/resuming on Asus laptops.

Cheers

Latest Articles

Thu, Apr 18
- 05:05 Coming soon to a -current system near you: parallel raw IP input (0)
Wed, Apr 17
- 05:33 In -current, default write format for tar(1) changed to "pax" (10)
Wed, Apr 10
- 18:50 OpenSMTPD 7.5.0p0 Released (2)
Tue, Apr 09
- 04:49 20 years since "and we're just starting": undeadly.org turns 20 (2024-04-09) (13)
Fri, Apr 05
- 06:16 OpenBSD 7.5 released (3)
Thu, Mar 28
- 18:18 LibreSSL 3.8.4 and 3.9.1 released (0)
Tue, Mar 12
- 06:53 OpenSSH 9.7/9.7p1 released! (0)
Mon, Mar 11
- 11:28 Game of Trees 0.97 released (0)
Sun, Mar 10
- 09:06 LibreSSL versions 3.8.3 and 3.9.0 released (0)

Credits

Copyright © 2004-2008 Daniel Hartmeier. All rights reserved. Articles and comments are copyright their respective authors, submission implies license to publish on this web site. Contents of the archive prior to April 2nd 2004 as well as images and HTML templates were copied from the fabulous original deadly.org with Jose's and Jim's kind permission. This journal runs as CGI with httpd(8) on OpenBSD, the source code is BSD licensed. undeadly \Un*dead"ly\, a. Not subject to death; immortal. [Obs.]